Skip to content

feat: add returning overload to tcp_acceptor::accept()#274

Merged
mvandeberg merged 1 commit into
cppalliance:developfrom
mvandeberg:pr/227-accept-overload
Jun 11, 2026
Merged

feat: add returning overload to tcp_acceptor::accept()#274
mvandeberg merged 1 commit into
cppalliance:developfrom
mvandeberg:pr/227-accept-overload

Conversation

@mvandeberg

@mvandeberg mvandeberg commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Add accept() with no arguments returning io_result<tcp_socket>, so the acceptor constructs the peer socket itself instead of requiring the caller to pass one in:

auto [ec, peer] = co_await acc.accept();

Closes #227

Add accept() with no arguments returning io_result<tcp_socket>, so the
acceptor constructs the peer socket itself instead of requiring the caller
to pass one in:

    auto [ec, peer] = co_await acc.accept();
@cppalliance-bot

Copy link
Copy Markdown

An automated preview of the documentation is available at https://274.corosio.prtest3.cppalliance.org/index.html

If more commits are pushed to the pull request, the docs will rebuild at the same URL.

2026-06-11 17:02:30 UTC

@cppalliance-bot

Copy link
Copy Markdown

GCOVR code coverage report https://274.corosio.prtest3.cppalliance.org/gcovr/index.html
LCOV code coverage report https://274.corosio.prtest3.cppalliance.org/genhtml/index.html
Coverage Diff Report https://274.corosio.prtest3.cppalliance.org/diff-report/index.html

Build time: 2026-06-11 17:16:59 UTC

@codecov

codecov Bot commented Jun 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.73%. Comparing base (a0d0d1c) to head (9cb4ca0).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #274   +/-   ##
========================================
  Coverage    77.73%   77.73%           
========================================
  Files           96       96           
  Lines         7234     7234           
  Branches      1764     1764           
========================================
  Hits          5623     5623           
  Misses        1102     1102           
  Partials       509      509           
Files with missing lines Coverage Δ
...clude/boost/corosio/native/native_tcp_acceptor.hpp 90.90% <ø> (ø)
include/boost/corosio/tcp_acceptor.hpp 91.83% <ø> (ø)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0d0d1c...9cb4ca0. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mvandeberg mvandeberg merged commit ccdaf15 into cppalliance:develop Jun 11, 2026
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tcp_acceptor::accept() should support returning the peer socket

2 participants