Skip to content

ProcessExecutor: avoid explicit usage of suppressions#4989

Open
firewave wants to merge 1 commit into
cppcheck-opensource:mainfrom
firewave:proc-suppr
Open

ProcessExecutor: avoid explicit usage of suppressions#4989
firewave wants to merge 1 commit into
cppcheck-opensource:mainfrom
firewave:proc-suppr

Conversation

@firewave
Copy link
Copy Markdown
Collaborator

The hasToLog() call performs this check.

@firewave firewave marked this pull request as draft April 20, 2023 12:48
@firewave
Copy link
Copy Markdown
Collaborator Author

firewave commented Apr 20, 2023

I am not sure this should be changed after all. The way the suppressions are checked is really hard to follow. I think we need some refactoring of where this is done so there's a single point for this and not two or three (or possibly more) of them. Will require some hacking and several other PRs merged first I guess.

@firewave
Copy link
Copy Markdown
Collaborator Author

firewave commented May 17, 2026

I took another look and the change looks correct to me. Explicit usage of the suppressions feels wrong and it is issued by the parent process and the hasToLog() is used for all errors which are being transferred to it.

Also the test coverage of the suppressions is much more improved so if the CI passes we can be confident it doesn't trigger some weird side effect (which should not be happening at all since the behavior is functionally the same).

@firewave firewave marked this pull request as ready for review May 17, 2026 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant