respect alt text translation method from the start#19067
Open
i-just wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR changes how the translation method for asset alt text is processed.
Up until now, when you first added alt text to an asset, it was propagated to all sites, not just those defined by the selected translation method. The translation method was respected from the second save. This behaviour was intentional, but after issue #19052 was raised, we discussed it internally and decided to change it for 5.11 (and 6) as it’s not the best from the accessibility point of view.
From now on:
assets.altcolumn is ignored and will be removed in v6assets_sites.altis NULL (or where theassets_sitesrow doesn’t exist), it copies over the value fromassets.altassets.alttoassets_sites.altaccording to the chosen translation setting, as it ensures we’re not changing the alt text developers might expect during the update, but at the same time allows us to no longer use theassets.altcolumn.(Separate PR for v6: #19072)
Related issues
#19052