Skip to content

refactor(patches): rename patch files for Windows compatibility and a…#422

Merged
KambleSahil3 merged 1 commit into
mainfrom
feat/JSONLD_JWTVC
Jul 3, 2026
Merged

refactor(patches): rename patch files for Windows compatibility and a…#422
KambleSahil3 merged 1 commit into
mainfrom
feat/JSONLD_JWTVC

Conversation

@sagarkhole4

@sagarkhole4 sagarkhole4 commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

…dd package.json export

Summary by CodeRabbit

  • Bug Fixes
    • Improved credential filtering so query results now match the intended credential format more reliably.
    • Prevented empty values from overwriting existing credential and presentation fields, reducing missing or unexpected data.
    • Fixed access to the default document loader so it can be used more consistently across supported builds.

…dd package.json export

Signed-off-by: Sagar Khole <sagar.khole@ayanworks.com>
@sagarkhole4 sagarkhole4 self-assigned this Jul 3, 2026
@sagarkhole4 sagarkhole4 requested a review from KambleSahil3 July 3, 2026 14:54
@sonarqubecloud

sonarqubecloud Bot commented Jul 3, 2026

Copy link
Copy Markdown

@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 30a680f6-12d4-4a94-9cf8-a5d7472209e5

📥 Commits

Reviewing files that changed from the base of the PR and between 3f9d90e and 4ddbe53.

📒 Files selected for processing (1)
  • patches/@credo-ts+core+0.6.2+002-fix-export-defaultDocumentLoader.patch

📝 Walkthrough

Walkthrough

This PR modifies a patch file for @credo-ts/core, adding a package.json exports mapping entry for the built VC data-integrity documentLoader.mjs module, wiring import/require to the .mjs file and types to the .d.mts file.

Changes

Package Export Patch

Layer / File(s) Summary
Add documentLoader exports mapping
patches/@credo-ts+core+0.6.2+002-fix-export-defaultDocumentLoader.patch
Adds a new subpath export entry for ./build/modules/vc/data-integrity/libraries/documentLoader.mjs in the package.json exports map, pointing import/require to the built .mjs and types to the .d.mts.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

  • credebl/agent-controller#323: Both PRs change how the W3C defaultDocumentLoader/document loader is provided/consumed, with the retrieved PR conditionally injecting the loader while this PR exports its entry point.
  • credebl/agent-controller#421: The DCQL $or format restriction, conditional id/expirationDate assignment, and the defaultDocumentLoader export mapping match the same functional fixes in this retrieved PR.

Suggested labels: chore

Suggested reviewers: sairanjit, ankita-p17, RinkalBhojani

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title mentions patch-file refactoring, but it is truncated and too vague to clearly describe the actual changes. Use a complete, specific title that names the main change, such as the new package export and document loader patch update.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/JSONLD_JWTVC

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@KambleSahil3 KambleSahil3 merged commit 77a36c7 into main Jul 3, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants