OCM/OCM-MLS: Standardize on base64url#383
Open
mickenordin wants to merge 2 commits into
Open
Conversation
We use base64 in several places, in particular the invitation strings needs to be URL safe. This commit standardizes on base64url encoding in all places where we use base64, including in diagrams and in the IETF-OCM-MLS draft. The example invite string: YTU1YTk2NmUtMTVjMS00Y2I5LWEzOWQtNGU0YzU0Mzk5YmFmQGNsb3VkLmV4YW1wbGUub3Jn can be decoded using standard GNU coreutils like this: echo -n 'YTU1YTk2NmUtMTVjMS00Y2I5LWEzOWQtNGU0YzU0Mzk5YmFmQGNsb3VkLmV4YW1wbGUub3Jn' | basenc -d --base64url and yields: a55a966e-15c1-4cb9-a39d-4e4c54399baf@cloud.example.org
glpatcern
approved these changes
Jul 9, 2026
glpatcern
left a comment
Member
There was a problem hiding this comment.
Perfect, this is very unambiguous
thibmeu
reviewed
Jul 9, 2026
thibmeu
left a comment
There was a problem hiding this comment.
much clearer. i don't know about the state of implementations. it might be worth checking if this is breaking and update them accordingly
Member
|
I have to remind us that this can become a bit misused as we have seen in the Reva based platforms other than the CERNBox in the past year's EOSC efforts. while its fine for the invite to be base64, its definitely not fine for the actual OCM identifier of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use base64 in several places, in particular the invitation strings needs to be URL safe. This commit standardizes on base64url encoding in all places where we use base64, including in diagrams and in the IETF-OCM-MLS draft.
The example invite string:
YTU1YTk2NmUtMTVjMS00Y2I5LWEzOWQtNGU0YzU0Mzk5YmFmQGNsb3VkLmV4YW1wbGUub3Jn
can be decoded using standard GNU coreutils like this:
echo -n 'YTU1YTk2NmUtMTVjMS00Y2I5LWEzOWQtNGU0YzU0Mzk5YmFmQGNsb3VkLmV4YW1wbGUub3Jn' | basenc -d --base64url
and yields: a55a966e-15c1-4cb9-a39d-4e4c54399baf@cloud.example.org