Repository navigation
Teach port and smoke proof in the pstack workflow skills #747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -25,7 +25,7 @@ Decompose the question into 2 to 4 angles, each a distinct slice of the subsyste | |
|
|
||
| ## 3. Synthesize (complex only) | ||
|
|
||
| Once all explorers have returned, spawn one explainer with `references/explainer-prompt.md` and every explorer's findings filled in. | ||
| Once all explorers have returned, harvest each explorer's final report into one scratch file by path, then point the explainer at that file only. Reconcile each explorer claim against a traced call path, the generator entry versus config-only strings, before synthesis. Spawn one explainer with `references/explainer-prompt.md` and that scratch file filled in. | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Explainer template ignores scratch fileMedium Severity · Logic Bug Complex Reviewed by Cursor Bugbot for commit 4d878d5. Configure here. |
||
|
|
||
| ## 4. Present | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,7 +10,7 @@ | |
| - **Shared mutable state.** Default to splitting the target (the **separate-before-serializing-shared-state** principle skill). Serialize only for real invariants. | ||
| - **Smallest safe decomposition.** If one worker is best, name why. | ||
| 4. Delegate code-writing to a subagent using your configured feature model (default `grok-4.7-xhigh-fast`) with a specific scope (file paths, named data shape and its organizing structure per **principle-model-the-domain**, a state machine over scattered booleans, a table/registry over branching, a typed model over repeated shape assumptions, chosen before the delegate writes logic, and success criteria). Pick each subagent's reasoning level and fast or standard speed for the job, per the Subagents section. When the implementation admits multiple valid shapes (error handling, abstraction layer, test structure), delegate via the **arena** skill instead so the runners surface the alternatives and the cross-judge guards the pick. Mandatory: no skip-with-reason escape, and Laziness Protocol does not override it (the gain is review separation, not lines saved). A subagent forbidden to spawn satisfies this by owning the diff directly with the same review separation. No "standing by" reply that waits on a nested agent. Comments per **Comments**. Surgical edits, re-ground against the source for upstream-derived files. Port shared-primitive improvements to all consumers and verify each. Commit liberally. | ||
| 5. Verify on the matching surface. "Inconclusive" or wrong-surface is not a pass. Flag it. | ||
| 5. Verify on the matching surface. "Inconclusive" or wrong-surface is not a pass. Flag it. After any delegate or smoke, read the serial log or equivalent capture for the expected strings before advancing the checkpoint. Do not mark the work done, push it, or update a plan status until the host check and the cross-target protection-domain check both exit zero on the same tree. | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Feature gate blocks non-port workHigh Severity · Logic Bug Feature step 5 now withholds done, push, and plan updates until Reviewed by Cursor Bugbot for commit 4d878d5. Configure here. |
||
| 6. Rebase into small, ordered commits. Stack follow-ups. | ||
| Use the **sequence-verifiable-units** principle skill, building, verifying, and committing each small unit before the next. | ||
| 7. If the design is contested, `interrogate` before shipping. | ||
|
|
||


There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Arena framing requires generator tables
Medium Severity · Logic Bug
Arena Phase A now requires every bakeoff to name features that split host or generator tables from the default build and to state what the generator emits today, including stale metadata. Arena frames design and code contests of any kind, so that contract ships a firmware-shaped prompt on trees that have no generator.
Reviewed by Cursor Bugbot for commit 4d878d5. Configure here.