Repository navigation
Conversation
…d secret Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Google Cloud BigQuery plugin was set up for sign-in with nothing to configure. That can't work: Google's OAuth server doesn't support Dynamic Client Registration, so users have to bring their own OAuth client. This change asks for an OAuth Client ID and Client Secret, matching the BigQuery connector UI.
plugin.json: adds requiredCLIENT_IDandCLIENT_SECRETvariables. The secret is a password field (writeOnly,format: password). Bumps the plugin to 1.1.0.mcp.json: passes both values inauthand requestshttps://www.googleapis.com/auth/bigquery, the only scope listed in the server's protected resource metadata (/.well-known/oauth-protected-resource/mcp).README.md: adds setup steps: create a Web application OAuth client in Google Cloud, register the desktop (http://localhost:8787/callback) and web (https://www.cursor.com/agents/mcp/oauth/callback) redirect URIs, then enter the credentials in the plugin settings.CHANGELOG.md: adds a 1.1.0 entry.The service-account option isn't included. The plugin still only signs in with each user's own Google account.
Test plan
node scripts/validate-plugins.mjsMade with Cursor
Note
Medium Risk
Changes how users authenticate to BigQuery MCP and requires storing OAuth client secrets in plugin configuration, though it follows the same BYO-OAuth pattern as other integration plugins.
Reviewed by Cursor Bugbot for commit 1f8ee6d. Bugbot is set up for automated code reviews on this repo. Configure here.