Skip to content

CM-65436: retry scan notification on 404 after presigned upload #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mateusz-sterczewski wants to merge 5 commits into
base: main
Choose a base branch
from
+9 −0
Open

CM-65436: retry scan notification on 404 after presigned upload #471

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f995885
CM-65436: retry scan notification on 404 after presigned upload
mateusz-sterczewski Jun 5, 2026
d62a142
style: ruff import sort
mateusz-sterczewski Jun 5, 2026
a8978ae
refactor: inline retry using Retrying context manager
mateusz-sterczewski Jun 5, 2026
c863d31
refactor: move upload-not-found retry to scan_client
mateusz-sterczewski Jun 5, 2026
bb3993d
chore: add comment explaining retry placement
mateusz-sterczewski Jun 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions cycode/cyclient/scan_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@

import requests
from requests import Response
from tenacity import retry, retry_if_exception, stop_after_attempt, wait_random_exponential

from cycode.cli import consts
from cycode.cli.config import configuration_manager
Expand Down Expand Up @@ -166,6 +167,14 @@ def upload_to_presigned_post(
raise SlowUploadConnectionError from e
raise

# Ideally this retry would live in _execute (CycodeClientBase) so all callers benefit,
# but that requires making the retry predicate configurable per-call — a larger refactor.
@retry(
retry=retry_if_exception(lambda e: isinstance(e, RequestHttpError) and e.status_code == 404),
stop=stop_after_attempt(3),
wait=wait_random_exponential(multiplier=1, min=1, max=5),
reraise=True,
)
def scan_repository_from_upload_id(
self,
scan_type: str,
Expand Down
Loading