Repository navigation
Conversation
The test recipes call `uv run --project ../..` without --python, so uv honoured the root .python-version pin (3.12) and rebuilt the venv the sync step had created on 3.13/3.14. Both non-3.12 legs have run on 3.12 since zarr-developers#4222. Set UV_PYTHON at job level so every uv call inside the recipes uses the matrix interpreter, and add a step that fails if the interpreter drifts again. Closes zarr-developers#4384 Assisted-by: ClaudeCode:claude-opus-5-5
Owner
Author
|
🤖 AI text below 🤖 Closing: merged upstream as zarr-developers#4390. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
Fix for zarr-developers#4384.
The zarr-indexing
testjob syncs the repo-root venv on the matrix Python, butjust test/just test-tensorstorethen calluv run --project ../..with no--python. uv honours the root.python-version(3.12), rejects the 3.13/3.14 venv, and rebuilds it on 3.12, so thepy=3.13andpy=3.14legs have run on 3.12 since zarr-developers#4222.Changes (workflow only):
env: UV_PYTHON: ${{ matrix.python-version }}, the fix proposed by @glaziermag in the issue. Every uv call inside the recipes inherits the matrix interpreter, and the justfile stays interpreter-agnostic for local use.--pythonfrom the sync step and correct its comment, which claimed the step pinned the interpreter.Check interpreterstep that fails if the venv interpreter doesn't match the matrix version, so a quiet fallback like this one turns the job red.A package-local
.python-versionwouldn't help: with--project ../.., uv reads the pin from the root project, and a single pin can't serve a three-version matrix anyway.Verified locally (uv 0.12.13) by simulating the 3.13 leg: the check passes,
just testruns 1739 passed on 3.13; withoutUV_PYTHON, the check fails withAssertionError: 3.12. actionlint and zizmor are clean.No changelog fragment: CI-only change.
🤖 Generated with Claude Code