Repository navigation
Conversation
- Execute and Drop Expired buttons stayed disabled on a fresh page load even when proposals were shown as Executable. useProposals filtered by status inside the query function with the cycle info known at the first fetch (block 0 before the TzKT websocket delivers), under a cache key that never changed. The list is now fetched once per DAO and the status filter is applied at render time with the current cycle info. - Contract Call proposals pushed the form's XTZ amount as mutez. Converted to mutez before building the lambda. - Proposal detail page labelled every proposal "Treasury Proposal"; lambda proposals now read Add Function, Remove Function, Execute Function or Contract Call. Verified on a local sandbox stack (deposit, enable ACI, contract call with 1 XTZ attached, vote, Execute on a fresh load; target contract received 1 tez and the string). Claude-Session: https://claude.ai/code/session_01UG9AFKKU31ba2d9QNLV44R
✅ Deploy Preview for tezos-homebase ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
…-votes hint in the vote dialog - In a DAO without the aci_executor handler, choosing Contract Call opened two dialogs on top of each other: the proposal dialog with a bare "deploy" message and a second dialog whose open state was never released, so neither could be closed and the page had to be reloaded. The explanation and the Submit button (which leads to the add-function proposal) now live inside the single proposal dialog, which closes normally. - The vote dialog explains why the maximum is lower than expected when the voter still has tokens staked on executed or dropped proposals, with a link to the User page where Unstake releases them. Claude-Session: https://claude.ai/code/session_01UG9AFKKU31ba2d9QNLV44R
Collaborator
Author
|
Two more fixes pushed to this branch:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the lambda feature test. The on-chain mechanism and the backend endpoint (homebase-lite-backend #42, #43) are fixed; this covers the three frontend issues found.
Execute / Drop Expired buttons disabled on a fresh load.
useProposals(dao, status)applied the status filter inside the query function using the cycle info available at the first fetch, which is block 0 until the TzKT websocket delivers a head, and cached the result under a key that never changed. So on a fresh load the list showed a proposal as Executable while the toolbar button stayed disabled until a remount or the 30 s refetch. The hook now fetches the list once per DAO and filters at render time with the live cycle info (useMemo). TheisLoadingstate that never flipped to false is gone too.Contract Call amount. The form takes XTZ but the generated lambda did
PUSH mutez <amount>, so 1 XTZ attached 1 mutez. Converted to mutez before building the lambda.Proposal detail label. Every proposal read "Treasury Proposal"; lambda proposals now read Add Function, Remove Function, Execute Function or Contract Call.
Verified on a local sandbox stack driven through the real UI: deposit, enable ACI, a contract call with 1 XTZ attached, vote, Execute clicked on a freshly loaded page; the target contract received 1,000,000 mutez and the string from the form.
https://claude.ai/code/session_01UG9AFKKU31ba2d9QNLV44R