Migrate the Go module to Dang v2 - #39
Open
matipan wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DAGGER_GO_WORKSPACE_IDfrom module container definitionsWhy
The include helper already supported indexing a mounted, content-addressed workspace snapshot, but test-directory discovery and per-directory include discovery still reconnected to Dagger through a serialized
WorkspaceID.Workspace IDs are scoped to a client session. Embedding one in
DAGGER_GO_WORKSPACE_IDchanged the helper container definition on every invocation even when repository contents were unchanged, preventing downstream work from reusing cache across CLI sessions.The local index now writes both include patterns and test-directory lists for every module in one pass.
GoModule.testDirectoriesreads those outputs and passes the module's discovered inputs into eachGoDirectory, so the active module path no longer needs an ambient workspace lookup or privileged nested execution for discovery.The public behavior remains the same: module discovery, local replaces, Go directives, per-directory tests, lint, test, and generate retain their existing APIs and selection semantics.
Validation
go test ./...inhelpers/go-includesbase-checkcgo-cxx-lint-checkdiscovery-checkgenerate-checkgo-mod-replace-checkmodule-introspection-checknested-module-directive-checkper-module-directive-checkselection-checksingle-module-check