Refactor YAML handling by centralizing reserved word checks and byte escaping - #836
Open
moritz-gross wants to merge 1 commit into
Open
moritz-gross wants to merge 1 commit into
moritz-gross wants to merge 1 commit into
Conversation
Linux library size: 0.58 MiB (0.00%)
Built with default features, Rust 1.96.0, and Ubuntu 24.04. Workflow run. |
Collaborator
Author
|
CI failure looks unrelated: |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
both
pretty_printandrules_archivehave the same tables for working with YAML scalars.Generally, I think there is much more YAML handling that can be consolidated.
I don't really know how this affects
build.rsandpackage_rules.rs(or even what those really do in the first place).Codex suggested to add
#[path = "src/yaml_helpers.rs"], as otherwise these other crate roots don't manage to findsrc/yaml_helpers.rswhich they depend on.Anyway, I think the idea here makes sense, I'm mostly just not sure about how to properly wire this up in Rust / the project structure.