canonicalize double exclamation !! to speak as double factorial - #837
Open
AdamMagued wants to merge 1 commit into
Open
AdamMagued wants to merge 1 commit into
AdamMagued wants to merge 1 commit into
Conversation
Linux library size: 0.58 MiB (0.00%)
Built with default features, Rust 1.96.0, and Ubuntu 24.04. Workflow run. |
Collaborator
|
When I wrote this issue, I didn't even catch that it's already covered and just needs to be normalized. @NSoiffer what do you think? Also, I've not really worked with the |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #806.
When
!!is encountered in<mo>!!</mo>, it was previously left as literal ASCII exclamation marks and spoken as"5 !!"rather than"5 double factorial".This change:
"!!"to"\u{203C}"("‼") incanonicalize_mo_text, aligning with the existing rules for double factorial across languages."‼"tooperator-info.inwith postfix operator type and priority 810 (matching single and double factorial operators).symbols_and_adornments.rsverifying that<math><mn>5</mn><mo>!!</mo></math>produces"5 double factorial"in ClearSpeak and SimpleSpeak.