Reject nonexistent requested paths during asset discovery - #1932
Draft
AtomicGlance wants to merge 1 commit into
Draft
AtomicGlance wants to merge 1 commit into
AtomicGlance wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1932 +/- ##
==========================================
+ Coverage 78.29% 78.34% +0.04%
==========================================
Files 92 92
Lines 14068 14103 +35
==========================================
+ Hits 11015 11049 +34
- Misses 3053 3054 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1094.
find_dandi_files() currently allows nonexistent paths to be silently ignored or represented as assets. This change checks every requested root before yielding any files and raises FileNotFoundError with the offending filename.
The check uses lstat() so broken symlinks remain discoverable. This preserves DANDI’s missing-content handling for unfetched DataLad files. Existing empty directories still return no assets, and no additional recursive walk is introduced.
Tests cover missing paths with recognized, unrecognized, and hidden names; both allow_all settings; multiple requested roots; empty directories; and broken symlinks. A CLI regression test also confirms that dandi validate retains its existing missing-path error.
Validation on Windows with Python 3.13: