DAOS-18910 cart: preserve UCX provider across re-init#18195
Draft
wangshilong wants to merge 1 commit intorelease/2.6from
Draft
DAOS-18910 cart: preserve UCX provider across re-init#18195wangshilong wants to merge 1 commit intorelease/2.6from
wangshilong wants to merge 1 commit intorelease/2.6from
Conversation
|
Ticket title is 'daos_test/suite.py:DaosCoreTest.test_daos_pool - POOL9 MGMT_POOL_FIND rpc failed to 6 ranks: DER_NONEXIST(-1005)' |
Client re-initialization could fail when the attach info used a UCX provider such as ucx+dc_x. The first daos_init() succeeded, but after daos_fini() a second daos_init() could return DER_NONEXIST because CaRT no longer recognized the UCX provider string. The problem was that UCX provider handling depended on mutating the global provider dictionary at init time and restoring it at finalize time. That made re-init fragile and also left provider parsing inconsistent between init and URI parsing paths. Fix this by treating ucx+* strings as CRT_PROV_UCX without rewriting the global provider table, and by storing the concrete provider string in per-provider runtime config so later URI generation and logging keep the original UCX transport name. Signed-off-by: Wang Shilong <shilong.wang@hpe.com>
wangshilong
force-pushed
the
shilongw/DAOS-18910-2.6
branch
from
fc9749c to
c676850
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Client re-initialization could fail when the attach info used a UCX provider such as ucx+dc_x. The first daos_init() succeeded, but after daos_fini() a second daos_init() could return DER_NONEXIST because CaRT no longer recognized the UCX provider string.
The problem was that UCX provider handling depended on mutating the global provider dictionary at init time and restoring it at finalize time. That made re-init fragile and also left provider parsing inconsistent between init and URI parsing paths.
Fix this by treating ucx+* strings as CRT_PROV_UCX without rewriting the global provider table, and by storing the concrete provider string in per-provider runtime config so later URI generation and logging keep the original UCX transport name.
Steps for the author:
After all prior steps are complete: