Repository navigation
fix: keep tab controls on split panes and the window draggable from the top - #446
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Fixes two problems caused by hiding the tab bar for a single tab (#432).
Summary
PaneContainerView.showsTabStripalso returns true when the split tree has more than one pane. On macOS 26 the native chrome portal follows the same flag, so the focused pane gets its new-tab and split controls back too.TabBarDragZoneViewat the strip's height instead.BonsplitTabDragUITests/testSplitPanesWithOneTabEachKeepTheirTabBars, backed by aPROGRAMA_UI_TEST_BONSPLIT_SPLIT_PANESoption in the existing tab drag harness that builds the second tab as a right split.The first commit adds only the split test, so its runs fail; the next adds the fix. There is no automated test for the window drag: CI runners drop synthetic mouse drags, the same reason the tab reorder test is skipped.
Test Plan
BonsplitTabDragUITestsclass still passes apart from the known reorder test