Repository navigation
Conversation
Builds up to 2026-09-30 flagged closed windows isHidden in the session snapshot. Nothing writes the field any more, so the restore-time filter, the shell hang-up for those windows and their test go.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Removes code that handled session snapshots from builds released before 2026-09-30, which marked windows you had closed as hidden. Current builds never write that flag. After this lands, if someone upgrades straight from one of those old builds, a window they had closed comes back as a normal window instead of being skipped.
Do not merge before 2026-10-30. That date is the end of the upgrade window for builds that still write the flag.
Summary
SessionWindowSnapshotlosesisHidden/isHiddenWindow.windowsToRestoreno longer filters, andhiddenWindows(from:)is removed.AppDelegatelosesendShellsOfHiddenWindowsandstartupEndedHiddenSessionIds. The orphan reconciler's known-session set now starts empty.testWindowsToRestoreSkipsHiddenWindowsAndOlderSnapshotsStayVisibleis deleted. Every assertion in it checked the removed field.Codableand a plainJSONDecoder, which ignores the unknownisHiddenkey.AppDelegate+SessionSnapshotPersistence.swift:203) never sets the field. Its last writer was removed in 85b2c3c.Test Plan
build-for-testing(Debug) succeeds locally.python3 scripts/check-structural-budgets.pypasses.