Repository navigation
fix: show a Claude question as waiting, not as a permission request - #458
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Claude asks you a question (AskUserQuestion), the sidebar said "Claude needs your permission". It now shows the question itself, marked as waiting. A real tool-approval prompt that comes later still reads as a permission request.
Claude Code sends the same notification for a question dialog as for a tool approval, so the hook can't tell them apart from the notification alone. The hook now remembers the open question from the PreToolUse event and forgets it once Claude moves on (next tool, new prompt, or end of turn).
The first commit adds the regression test on its own, so it should go red; the second commit is the fix.
Not covered: when the Programa socket is unreachable, the fallback path still labels a question as a permission request.