Add preference to disable automatic AI model update checks - #21922
Merged
TurboGit merged 1 commit intoAug 23, 2026
Conversation
Contributor
|
@andriiryzhkov : many thanks for considering this feature proposal! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #21514
darktable checks the model repositories for newer versions whenever the AI preferences page is opened, with no way to stop it. This adds
plugins/ai/auto_check_updates(default on, so nothing changes unless you ask) and a "check for updates" button for when it is off.The toggle sits with the other global switches rather than beside the model list – it governs whether darktable reaches the network on its own, which is what someone auditing that page is looking for.
The check is asynchronous, so the button goes insensitive until every repository has reported back, then summarises: how many models have updates, or that everything is current, with an "update now" that runs the existing per-model download. A new
DT_SIGNAL_AI_UPDATE_CHECK_DONEcarries the completion.Two pre-existing bugs had to be fixed for any of this to work, both in
ai_models.cand both independent of the preference:dt_ai_models_refresh_status()reset every installed model toDOWNLOADED, wiping theUPDATE_AVAILABLEflag the check had just set – so no update check has ever been able to show a result.github_asset, but were still flagged as updatable; the download refuses them, so the model list offered an update that could not be applied.