lighttable: clamp stale thumbnail offsets - #21952
Merged
Merged
Conversation
Arecsu
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21860
The filemanager could restore a stale thumbnail offset after leaving preview/culling. When that offset was beyond the current collection, the redraw queried past the end and loaded zero thumbnails, leaving the lighttable blank.
The filemanager now clamps restored offsets to a valid row-aligned position before rebuilding thumbnails.
The issue was reported on Windows, but the affected state restoration is shared across platforms. Windows testing is still required. Seems somewhat flaky to trigger though so unsure about how to test this properly