opencl: move the image2d_t bilinear resampler into bilinear.cl - #22046
Merged
Conversation
The guided-laplacian highlight reconstruction carried its own copy of a bilinear resampling kernel in basic.cl, duplicating the buffer variants that now live in bilinear.cl. Move it there as bilinear_image and expose it through dt_interpolate_bilinear_image_cl(), so all bilinear resamplers share one home and highlights no longer keeps a private kernel handle. The kernel body is unchanged, image and buffer variants stay separate because OpenCL C cannot express one kernel over both image2d_t and global buffers. No functional change.
Contributor
Author
|
Given that bilinear resampling is also a "basic" operation, we could also move all of them to |
TurboGit
added
scope: codebase
da-phil
deleted the
pl/move_image2d_bilinear_resampler_into_common_bilinear_opencl_program
branch
August 30, 2026 19:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The guided-laplacian highlight reconstruction carried its own copy of a bilinear resampling kernel in basic.cl, duplicating the buffer variants that now live in bilinear.cl. Move it there as bilinear_image and expose it through dt_interpolate_bilinear_image_cl(), so all bilinear resamplers share one home and highlights no longer keeps a private kernel handle.
The kernel body is unchanged, image and buffer variants stay separate because OpenCL C cannot express one kernel over both image2d_t and global buffers.
No functional change. Tested locally against with a couple of images. But will follow-up with a full integration test run.
Disclaimer: this change was co-created with Claude.