colorequal: add visible toggle for showing color sliders

[stnKrisna]

The graph only supported toggling slider visibility via middle-click, which was undiscoverable. Add a section-style 'show color sliders' toggle below the hue shift slider, mirroring the options collapsible section's access pattern (label + solid-arrow toggle).

[anoderay]

I love using color EQs sliders as they offer much finer control compared to the graph, especially for hue adjustments. Having an UI option to toggle them besides the obscure middle click toggle is a good idea. I personally would prefer a checkbox within the three-lines-menu-button though.

And on the subject of Color EQs UI: I think the new-ish colour wheels shown upon right click in the hue tab don't work as well as the whiskers. They make selecting a very different hue easy but fine adjustments are much harder IMHO.

[stnKrisna]

The slider toggle by middle-click was there since the beginning of this module. If it’s purely up to me, I would remove the toggle and just display the numeric slider. This way, we standardize the input slider and expose the whiskers. The graph can be an alternative input method or simply visualization purpose.

From my lazy google search, the slider input pattern exists in Lightroom, snapseed, and capture one. I don’t see any reason why we need to reinvent the wheel by showing only the graph input by default.

If it’s okay, I would just remove the toggle and show the slider permanently.

[anoderay]

If it’s okay, I would just remove the toggle and show the slider permanently.

I think the sliders not being there has its reasons. If I recall correctly e.g. @jenshannoschwalm isn't a fan of them.

[jenshannoschwalm]

For me the sliders are "nothing". We had them when implementing the module and some people liked them so they are available. Absolutely no for "show always". I would accept the addition of the proposed "toggle" but for me it's just clobbering the UI.

[Donatzsky]

One problem with using sliders only is that's it's not immediately obvious what the curve does. At the same time, aren't the sliders needed for keyboard/midi shortcuts?

Having a "show sliders" option in the presets menu seems like a reasonable idea to me.

[TurboGit]

@jenshannoschwalm

I would accept the addition of the proposed "toggle" but for me it's just clobbering the UI.

A toggle or the collapsible section? It takes the same vertical space and is more Dt like.

BTW, if we go with the collapsible section the name should be simply "control sliders" no need for "display".

[jenshannoschwalm]

At the same time, aren't the sliders needed for keyboard/midi shortcuts?

That doesn't imply they should be visible :-)