Don't leave Nanny stuck in closing status when worker kill times out (fix flaky test_chaos_rechunk)#9317
Merged
Merged
Conversation
Contributor
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 19 files - 21 19 suites - 21 7h 8m 50s ⏱️ - 7h 6m 35s Results for commit b1bef38. ± Comparison against base commit 2d43f7f. This pull request removes 4155 and adds 100 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
4 tasks
test_chaos_rechunktest_chaos_rechunk
test_chaos_rechunktest_chaos_rechunk
b1bef38 to
5b013ee
Compare
test_chaos_rechunktest_chaos_rechunk
Fix test_chaos_rechunk flakiness on slow CI hosts with a Nanny stuck in Status.closing at teardown.
5b013ee to
5c735a7
Compare
test_chaos_rechunktest_chaos_rechunk)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_chaos_rechunkfrequently hangs, e.g. https://github.com/dask/distributed/actions/runs/28594679995/job/84786875121?pr=9315This is due to an underlying race condition in
Nannywhich is triggered on very slow hosts (like Windows CI frequently is).