ENH: testing: Add check_device parameter#835
Open
prady0t wants to merge 5 commits into
Open
Conversation
Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
prady0t
commented
Jul 6, 2026
Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
prady0t
commented
Jul 6, 2026
Contributor
Author
|
CC @j-bowhay |
j-bowhay
reviewed
Jul 7, 2026
j-bowhay
reviewed
Jul 7, 2026
j-bowhay
left a comment
j-bowhay
left a comment
Contributor
There was a problem hiding this comment.
It would be nice to have some tests :)
Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
Contributor
Author
|
Some irrelevant device checks have been removed as assert functions check for the device by default now. I've also added checks for non-default device. |
lucascolley
requested changes
Jul 7, 2026
prady0t
commented
Jul 13, 2026
Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
lucascolley
self-requested a review
July 14, 2026 09:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards: #833