Skip to content

ENH: add nanmax#847

Open
OmarManzoor wants to merge 1 commit into
data-apis:mainfrom
OmarManzoor:nanmax
Open

ENH: add nanmax#847
OmarManzoor wants to merge 1 commit into
data-apis:mainfrom
OmarManzoor:nanmax

Conversation

@OmarManzoor

Copy link
Copy Markdown
Contributor

Towards #789

  • Adds support for nanmax

@lucascolley

Copy link
Copy Markdown
Member

as mentioned earlier, would be nice to see a branch with this and nanmin working in sklearn

@lucascolley lucascolley added enhancement New feature or request new function labels Jul 13, 2026
@lucascolley lucascolley added this to the 0.11.1 milestone Jul 13, 2026
@lucascolley lucascolley changed the title ENH add nanmax ENH: add nanmax Jul 13, 2026
@OmarManzoor

Copy link
Copy Markdown
Contributor Author

How should we test? Will you merge this and then I need to adjust the version of array-api-extra in scikit-learn on my local system?

@lucascolley

Copy link
Copy Markdown
Member

you can checkout this branch of array-api-extra inside sklearn

@OmarManzoor

OmarManzoor commented Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

The CI in scikit-learn is 🟢

@lucascolley
lucascolley self-requested a review July 13, 2026 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request new function

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants