Open
Conversation
ghanse
force-pushed
the
gregory-hansen/uv-packaging
branch
from
c3309b1 to
edb0708
Compare
alexott
approved these changes
May 5, 2026
Collaborator
alexott
left a comment
alexott
left a comment
There was a problem hiding this comment.
lgtm, in general. A few comments
Comment on lines
-21
to
-25
| cache: 'pip' | ||
| cache-dependency-path: '**/pyproject.toml' | ||
| python-version: '3.12' | ||
| version: "0.11.2" | ||
|
|
||
| - name: Build wheels | ||
| run: | |
Collaborator
There was a problem hiding this comment.
Should we keep cache settings? Or it's not supported in the setup-uv github action?
| uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 | ||
|
|
||
| - name: Setup uv | ||
| uses: astral-sh/setup-uv@5a095e7a2014a4212f075830d4f7277575a9d098 |
Collaborator
There was a problem hiding this comment.
Maybe add a comment at the end of the line specifying what task version corresponds to that hash?
Collaborator
There was a problem hiding this comment.
Do we need this file? or just committed by accident?
| readme = "README.md" | ||
| license-files = { paths = ["LICENSE.md", "NOTICE.md"] } | ||
| requires-python = ">=3.12" | ||
| requires-python = ">=3.12,<3.14" |
There was a problem hiding this comment.
Pull request overview
This PR migrates the repository’s developer/build workflow from Hatch-managed environments to uv-managed locking, syncing, and execution while keeping hatchling as the build backend. It updates contributor docs, CI, and packaging metadata to align the repo with the new tooling approach.
Changes:
- Reworks packaging metadata and dependency management around
uv, including dependency groups, Python version bounds, and build constraints. - Replaces Hatch-based Makefile/CI commands with
uv sync,uv run, anduv build. - Refreshes contributor-facing docs/examples and adds uv-specific project metadata/files.
Review note: uv.lock is referenced by the PR description, but its full diff was not included in the supplied review context; it was only spot-checked via repository reads.
Reviewed changes
Copilot reviewed 16 out of 18 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
tests/e2e/conftest.py |
Updates PR/e2e library reference handling. |
src/python_data_sources/mqtt/mqtt_streaming.py |
Adjusts MQTT option parsing and minor formatting. |
README.md |
Refreshes install/dev instructions and example formatting. |
pyproject.toml |
Migrates dependency/env configuration to uv-style groups. |
Makefile |
Replaces Hatch commands with uv-based dev, lint, test, build, and lock targets. |
examples/zipdcm/zip-dicom-demo.ipynb |
Updates documented ZipDCM dependency requirements. |
coverage.xml |
Adds a generated coverage report artifact. |
CONTRIBUTING.md |
Rewrites contributor workflow around make dev / uv. |
.python-version |
Pins the local default Python version to 3.12. |
.pre-commit-config.yaml |
Broadens hook scope and tweaks formatter settings. |
.github/workflows/test.yml |
Migrates CI test/format/e2e jobs to uv-based commands. |
.github/workflows/test-release.yml |
Migrates test-release publishing flow to uv-based build/install steps. |
.github/workflows/release.yml |
Migrates release build workflow to uv-based build steps. |
.github/scripts/export_databricks_notebooks.py |
Mostly formatting/quote normalization cleanup. |
.github/scripts/convert_notebooks.py |
Mostly formatting/quote normalization cleanup. |
.build-constraints.txt |
Adds hash-pinned build constraints for build-system requirements. |
uv.lock |
Adds uv lockfile for resolved dependencies (full diff not provided in review context). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if os.getenv("REF_NAME"): | ||
| test_library_ref = f"{test_library_ref}.git@refs/pull/{os.getenv('REF_NAME')}" | ||
| return test_library_ref | ||
| return f"{test_library_ref}.git@{os.getenv('REF_NAME')}" |
| self.qos = int(options.get("qos", 2)) | ||
| self.keep_alive = int(options.get("keepalive", 60)) | ||
| self.clean_session = options.get("clean_session", False) | ||
| self.clean_session = options.get("clean_session", "false").strip().lower() == "true" |
|
|
||
| dev: | ||
| uv sync --all-extras | ||
|
|
|
|
||
| coverage: | ||
| $(UV_RUN) pytest --cov src --cov-report=html --timeout 30 tests/unit | ||
| open htmlcov/index.html |
| <!-- Generated by coverage.py: https://coverage.readthedocs.io/en/7.13.5 --> | ||
| <!-- Based on https://raw.githubusercontent.com/cobertura/web/master/htdocs/xml/coverage-04.dtd --> | ||
| <sources> | ||
| <source>/Users/gregory.hansen/Documents/GitHub/databricks-industry-solutions/python-data-sources/src</source> |
| self.qos = int(options.get("qos", 2)) | ||
| self.keep_alive = int(options.get("keepalive", 60)) | ||
| self.clean_session = options.get("clean_session", False) | ||
| self.clean_session = options.get("clean_session", "false").strip().lower() == "true" |
Comment on lines
19
to
+21
| - id: black | ||
| name: black | ||
| entry: black --line-length 100 | ||
| entry: black --line-length 120 |
Comment on lines
+53
to
+56
| uv pip install --index-url https://test.pypi.org/simple/ \ | ||
| --extra-index-url https://pypi.org/simple/ \ | ||
| python-data-sources==${{ steps.version.outputs.version }} | ||
| python -c "import python_data_sources; print('Import successful!')" No newline at end of file | ||
| uv run python -c "import python_data_sources; print('Import successful!')" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
uv sync/uv runuv.lock, removes per-source[tool.hatch.envs]frompyproject.toml(hatchling stays as the build backend)CONTRIBUTING.mdto remove stale hatch-envs guidance and document themake devsetup stepCloses #27