Fix permissions: [] to add default IS_OWNER instead of being treated as absent - #6046
Open
denik wants to merge 3 commits into
Open
Fix permissions: [] to add default IS_OWNER instead of being treated as absent#6046denik wants to merge 3 commits into
denik wants to merge 3 commits into
Conversation
ApplyBundlePermissions collapsed an empty permissions slice to nil, which FixPermissions then skipped (AsSequence fails on nil), so an explicit permissions: [] never got the default IS_OWNER for the current user. It was indistinguishable from omitting the block entirely. Track whether the permissions key was present and only collapse to nil when it was absent. An explicit empty list now survives as an empty sequence, so FixPermissions adds IS_OWNER, matching both a non-empty list and Terraform. The jobs/pipelines empty_list fixtures documented this as a known bug; that comment is now resolved. Co-authored-by: Isaac
Contributor
Approval status: pending
|
Collaborator
Integration test reportCommit: 652b793
14 interesting tests: 6 FAIL, 4 SKIP, 3 RECOVERED, 1 KNOWN
Top 4 slowest tests (at least 2 minutes):
|
Grants have no default owner (no FixPermissions analog), so grants: [] grants nothing rather than injecting a principal, and validate shows [] vs null for absent. The test also records a direct-vs-terraform divergence on create: direct emits a no-op PATCH with an empty body, terraform emits no request. Co-authored-by: Isaac
When a resource was created with grants: [] and no prior state, the direct engine created a grants node and fired a PATCH with no changes, while terraform emitted nothing. Skip the node in that case. The node is still kept when it exists in state, so removing all grants with grants: [] still plans an update and emits the removal PATCH. Co-authored-by: Isaac
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
An explicit
permissions: []on a resource was collapsed to nil byApplyBundlePermissions and then skipped by FixPermissions, so it never got
the default IS_OWNER for the current user — it behaved as if the block were
absent. The jobs/pipelines empty_list acceptance fixtures documented this as
a known bug.
Changes
Track whether the permissions key was present and only collapse to nil when
it was absent. An explicit empty list now survives as an empty sequence, so
FixPermissions adds IS_OWNER, matching both a non-empty list and Terraform.
Also handles the grants counterpart. Grants have no default owner, so
grants: []grants nothing, but the direct engine used to create a grantsnode and fire a no-op PATCH on first deploy while terraform emitted nothing.
Skip the node when the grants list is empty and absent from state; when it is
already in state the node is kept, so removing all grants with
grants: []still plans an update and emits the removal PATCH.