Skip to content

Reconfiguring aitools query to use consolidated StaticRendererWithTruncation - #6079

Open
tanishgupta-db wants to merge 5 commits into
databricks:mainfrom
tanishgupta-db:aitools-shared-static-render
Open

Reconfiguring aitools query to use consolidated StaticRendererWithTruncation#6079
tanishgupta-db wants to merge 5 commits into
databricks:mainfrom
tanishgupta-db:aitools-shared-static-render

Conversation

@tanishgupta-db

@tanishgupta-db tanishgupta-db commented Jul 27, 2026

Copy link
Copy Markdown

Changes

Routes databricks experimental aitools tools query static-table output through the shared tableview.RenderStatic renderer. RenderStatic adds a StaticOptions{Width, TruncateCells} config: aitools uses {Width: 0, TruncateCells: false} to preserve its exact current output (full cell values, separator capped at 40, no column dropping), while pipelines show uses truncation + terminal-width fitting.

Note

Stacked on #6033 (pipelines show). The diff will overlap until that merges; review this on top of it.

Why

Consolidate the two near-identical static table renderers into one shared implementation.

Tests

  • Unit tests.
  • Verified byte-identical old-vs-new output end-to-end (built both binaries, diffed aitools query on real data across the static/JSON/overflow cases).

@tanishgupta-db
tanishgupta-db marked this pull request as ready for review July 28, 2026 06:09
@github-actions

Copy link
Copy Markdown
Contributor

Approval status: pending

/acceptance/pipelines/ - needs approval

8 files changed
Suggested: @kanterov
Also eligible: @jefferycheng1, @lennartkats-db

/cmd/pipelines/ - needs approval

7 files changed
Suggested: @kanterov
Also eligible: @jefferycheng1, @lennartkats-db

/experimental/aitools/ - needs approval

Files: experimental/aitools/cmd/query.go, experimental/aitools/cmd/render.go, experimental/aitools/cmd/render_test.go
Suggested: @fjakobs
Also eligible: @MarioCadenas, @Shridhad, @atilafassina, @keugenek, @igrekun, @pkosiec, @pffigueiredo, @ditadi, @calvarjorge, @lennartkats-db

General files (require maintainer)

4 files changed
Based on git history:

  • @pietern -- recent work in cmd/pipelines/, ./, experimental/aitools/cmd/

Any maintainer (@andrewnester, @anton-107, @denik, @pietern, @shreyas-goenka, @simonfaltum, @renaudhartert-db, @janniklasrose, @lennartkats-db) can approve all areas.
See OWNERS for ownership rules.

@tanishgupta-db
tanishgupta-db force-pushed the aitools-shared-static-render branch from 3af984a to 66f4255 Compare July 29, 2026 07:33
@github-actions

Copy link
Copy Markdown
Contributor

An authorized user can trigger integration tests manually by following the instructions below:

Trigger:
go/deco-tests-run/cli

Inputs:

  • PR number: 6079
  • Commit SHA: 66f4255f48c93d330e68d5c656f531d8fb8881b5

Checks will be approved automatically on success.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant