Skip to content

Bump thrift dependency past GHSA-r67j-r569-jrwp #370

Description

@kylekennedy-spade

Summary

@databricks/sql currently pins thrift at a version that's flagged by GHSA-r67j-r569-jrwp (Apache Thrift Node.js bindings vulnerable to uncontrolled recursion). Downstream consumers running npm audit --audit-level=high in CI are now seeing this fail with "No fix available" because the lockfile-resolved thrift version falls inside the advisory's affected range.

Can be reproduced in any project that depends on @databricks/sql@^1.13.0

Requested change

Bump the thrift peer/runtime dependency in @databricks/sql to a version outside the advisory range (the next patched release on or after 0.23.0)

Activity

  1. andyedwardsibm commented on May 7, 2026

    @andyedwardsibm

    For clarity GHSA-r67j-r569-jrwp claims that @databricks/sql@0.23.0 thrift@0.23.0 is the fixed version

  2. andyedwardsibm commented on May 7, 2026

    @andyedwardsibm

    There is also https://nvd.nist.gov/vuln/detail/CVE-2026-43870, which is also fixed by @databricks/sql@0.23.0 thrift@0.23.0

  3. kylekennedy-spade commented on May 7, 2026

    @kylekennedy-spade
    Author

    @andyedwardsibm thanks, good call - I'll update the issue. In your comments though, I think you mean to be referencing thrift@0.23.0 rather than @databricks/sql?

  4. andyedwardsibm commented on May 7, 2026

    @andyedwardsibm

    Oo yes, my bad... fixing

  5. kylekennedy-spade commented on May 11, 2026

    @kylekennedy-spade
    Author

    This package is also now affected by GHSA-526f-jxpj-jmg2. Any update on a fix timeline for this?

  6. jorgeramirezamora commented on May 12, 2026

    @jorgeramirezamora

    Any update on this issue?

  7. msrathore-db commented on May 27, 2026

    @msrathore-db
    Contributor

    Thanks for reporting. This is being actively looked into and should be fixed with PR #390

  8. kGwozdoBayer commented on Jun 2, 2026

    @kGwozdoBayer

    Hey, 3 weeks later, this is still an issue. Any ETA on when will it be fixed @msrathore-db ?

    Image
  9. cclp94 commented on Jun 8, 2026

    @cclp94

    Hello, any updates on this and when the PR will be merged. We really need the HIGH sevs to be fixed

  10. kevin-boutin commented on Jun 9, 2026

    @kevin-boutin

    Here is some more notes of the CVE:

    Image
  11. juanjzunino commented on Jun 17, 2026

    @juanjzunino

    Thanks for reporting. This is being actively looked into and should be fixed with PR #390

    @msrathore-db any chance of adding the fix in the next release?

  12. andyedwardsibm commented on Jul 14, 2026

    @andyedwardsibm

    So... is v2.0.0 about to be released? Right now, there still isn't a released version of @databricks/sql available that has thrift@^0.23.0 as a dependency; @databricks/sql@1.17.0 still uses thrift@0.16.0

  13. vikrantpuppala commented on Jul 14, 2026

    @vikrantpuppala
    Collaborator

    working on it

  14. added a commit that references this issue on Jul 14, 2026
    c1a9d4b
  15. arunthomas32 commented on Jul 24, 2026

    @arunthomas32

    @vikrantpuppala @msrathore-db

    I had tried updating to 2.0.0 version and while running tests the following issue occured:

    .../node_modules/thrift/node_modules/uuid/dist-node/index.js:1
    export { default as MAX } from './max.js';
    ^^^^^^
    
    SyntaxError: Unexpected token 'export'
    
    

    For more details I had created a ticket.
    #461

    any help would be much appreciated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions