fix(metadata): accept null and empty primary-key namespace - #537
Draft
vuanhphung wants to merge 2 commits into
Draft
vuanhphung wants to merge 2 commits into
vuanhphung wants to merge 2 commits into
Conversation
Signed-off-by: Vu Anh Phung <vu.phung@databricks.com>
Signed-off-by: Vu Anh Phung <vu.phung@databricks.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep the public
PrimaryKeysRequestcontract unchanged (catalogName?: string,schemaName: string). Forward runtime null/undefined and explicit empty namespace strings to the kernel unchanged, matching Thrift. The Thrift implementation is unchanged.Depends on databricks/databricks-sql-kernel#379 and a published native kernel package containing that change. This draft does not include the package-version bump.
Tested: 1,350 Node unit tests passed, including all 16 namespace combinations for each backend. Production TypeScript checking, formatting, and linting passed. The rebuilt native binding passed the 16-case JavaScript smoke test.