[ug] Preserve unmanaged Claude family defaults - #928
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ANTHROPIC_DEFAULT_<FAMILY>_MODELvalues when no Coding Agent Config is presentContext
PR #444 preserved existing managed-file family defaults, including without a Coding Agent Config. PR #709 later introduced cross-workspace ownership tracking and intentionally re-derived defaults that matched ug's last write. That allowed managed workspace transitions to clear stale defaults, but also caused unmanaged launches to replace preexisting family defaults. This change restores the unmanaged preservation boundary without changing managed-config reconciliation.
The dedicated
test_unmanaged_claude_preserves_preexisting_family_defaultslive test verifies that its real workspace publishes no CodingAgentConfig, seeds/etc/claude-code/managed-settings.jsonwith all Claude family defaults, runs publicug configure, and requires those exact defaults to remain unchanged. It checks settings reconciliation and makes no inference claim.Testing
uv run --frozen ruff check src/ tests/uv run --frozen ruff format --check src/ tests/uv run --frozen ty check src/uv run --frozen pytest tests/test_integration_contract.py tests/test_agent_claude.py::TestWriteToolConfigManagedSettings::test_unmanaged_preserves_existing_family_defaults tests/test_managed_model_lifecycle.py::test_claude_model_lifecycle -q(39 passed)