fix(api): honor self-hosted email sender settings - #803
izadoesdev wants to merge 3 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
02602b1 to
db6a6a2
Compare
|
The latest updates on your projects. Learn more about Unkey Deploy
|
1 participant
Alarm notifications ignored configured sender addresses and used the hosted
databuddy.ccsender. Resolve them through the existingALERTS_EMAIL_FROM→EMAIL_FROMfallback, make the example alert override optional, and forward both sender variables through Turbo. Hosted sender defaults and per-alarm overrides remain unchanged.This six-file change covers notification sender resolution and its delivery regression test, the existing
@databuddy/envworkspace dependency,.env.example, and Turbo configuration. Self-hosted Compose wiring and setup documentation belong to companion #804; the two PRs can land independently.Validation: root
bun run lint, all 33 typecheck tasks, and all 27 root test tasks pass. The notifications suite passes 27 tests, including mocked outbound delivery and all four sender-precedence cases. The delivery regression also covers channel selection and the default recipient, replacing a duplicate target-construction test. Full pre-push command output was captured locally.AI-assisted implementation and verification with Codex.