fix(rpc): remove hosted billing requirements from self-hosting - #816
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The latest updates on your projects. Learn more about Unkey Deploy
|
0980cf0 to
2629c69
Compare
This comment has been minimized.
This comment has been minimized.
|
2629c69 to
ce315bd
Compare
|
@greptileai review this |
|
@greptileai review this. The current-head summary still says repository-rule violations remain, but no new finding is attached and all three original threads are fixed: shared AI preflight covers retries/actions before writes, the webhook handler has its actual result type, and env cleanup uses Reflect.deleteProperty. The credential cases use test.each. Please identify any remaining current-head file/line or update the summary; final head is 6e37075. |
|
@greptileai review this. Both new current-head findings are fixed in bbf93ed: the balance test reuses its existing failure predicate, and all delete operators introduced by this PR use Reflect.deleteProperty. Please review the final head. |
bbf93ed to
4d50018
Compare
|
@greptileai review this. Final head 4d50018 rebases onto staging and preserves its new dashboard test coverage with --isolate, fixing cached hosted environment state across test files. The failure reproduced as 153 passing and 2 failing tests before isolation; all 155 now pass. All 33 type tasks, 22 policy checks, and 29 pre-push tasks pass. Previous review fixes are retained. |
|
@greptileai review this. Final head c367789 fixes both UI style findings. An AST audit of all added TS/TSX lines also covered nested ternaries, paragraph text-pretty, prohibited types/delete, and await inside loops; the additional detail-page paragraph was fixed. Behavior is unchanged. All 155 dashboard tests, lint, 33 type tasks, and 29 pre-push tasks pass. |
With
SELFHOST=true, local analytics features and configured AI run without an Autumn account. Goals, funnels, flags, error analytics, and investigations retain their authorization checks while skipping hosted subscription limits. AI still requires the operator's provider key.The dashboard hides billing and upgrade prompts, disables its internal rollout flags, and shows an AI setup message when needed. Server billing calls, feedback credit redemption, Autumn webhooks, and webhook replay are disabled even when copied provider keys are present. Existing hosted billing paths remain enabled outside self-host mode.
Validation
Dependencies and overlaps
Based directly on staging. Depends on #806 for forwarding
SELFHOSTthrough Turbo; #804 supplies the self-host dashboard build setting and Compose setup. #814 and #815 complete the Redis and Kafka reductions; #808 documents the combined setup.Overlaps #790 in
packages/rpc/src/orpc.ts: the explicit self-host guard must remain before the hosted billing lookup. #806 adds an adjacent CI test step; retain both steps. #814 adds the same AI workspace dependency, which should appear once in the merged manifest and lockfile.AI-assisted implementation and verification with Codex. Draft for maintainer review; no production deployment performed.
Summary by cubic
With
SELFHOST=true, self-hosted instances no longer require an Autumn account for analytics or provider-backed features. Hosted billing calls are disabled even when stale billing keys are present; hosted behavior remains unchanged otherwise.Written for commit c367789. Summary will update on new commits.