Skip to content

This PR removed the unused protobuf definition for spanner.py for ingestion helper#545

Merged
shixiao-coder merged 4 commits into
datacommonsorg:masterfrom
shixiao-coder:remove-deprecated-proto-def
Jun 16, 2026
Merged

This PR removed the unused protobuf definition for spanner.py for ingestion helper#545
shixiao-coder merged 4 commits into
datacommonsorg:masterfrom
shixiao-coder:remove-deprecated-proto-def

Conversation

@shixiao-coder

Copy link
Copy Markdown
Contributor

No description provided.

@shixiao-coder shixiao-coder requested a review from vish-cs June 15, 2026 16:51

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request simplifies the Spanner database initialization by removing the loading and passing of proto descriptors (storage.pb) during the DDL update process. The corresponding unit tests have been updated to remove the mock file handling for the proto file. I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@codacy-production

codacy-production Bot commented Jun 15, 2026

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics -4 complexity

Metric Results
Complexity -4

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@shixiao-coder shixiao-coder merged commit da9f562 into datacommonsorg:master Jun 16, 2026
10 checks passed
@shixiao-coder shixiao-coder deleted the remove-deprecated-proto-def branch June 16, 2026 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants