Skip to content

fix: preserve market peer policy in generation installs - #394

Merged
yaojin3616 merged 2 commits into
mainfrom
codex/generation-peer-policy
Sep 11, 2026
Merged

fix: preserve market peer policy in generation installs#394
yaojin3616 merged 2 commits into
mainfrom
codex/generation-peer-policy

Conversation

@yaojin3616

@yaojin3616 yaojin3616 commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Desktop discarded the market’s --config.auto-install-peers=false retry option when converting an install into an isolated generation. Installing @kenz1117/dsh-ui-usage-billing@1.2.5 could therefore keep fetching an obsolete host peer and fail on the unpublished dsh-type-meta dependency even after the market requested recovery.

Forward the explicit boolean peer policy to the generation pnpm subprocess, supporting both kebab-case and camelCase. When omitted, inherit the Profile workspace’s explicit autoInstallPeers boolean so release-age recovery cannot consume the only retry before peer recovery. Without either setting pnpm retains its default. This is a targeted contract fix, not arbitrary pnpm argument forwarding or a change to third-party market code. Only the peer boolean is inherited; workspace paths and upstream version re-resolution are outside this change.

Validation:

  • 58 tests passed across generation-boundary, generation-installer, and market-installer.
  • Regression exercises failure then retry through the actual subprocess boundary, verifies both option spellings, and checks that version 1.2.4 is retained and visible after publication.
  • Production build and git diff --check passed.
  • Typecheck is blocked by existing TS18048 errors in test/desktop-client-ui.test.ts:108–109; that file is byte-identical to base main (5a93138).
  • Real dev Profile installation of the reported plugin succeeded through the generation boundary and published version 1.2.5. Added coverage for release-age failure followed by retry with inherited peer policy. Packaged Windows acceptance remains unverified.

@yaojin3616
yaojin3616 merged commit 9daf078 into main Sep 11, 2026
5 of 6 checks passed
@yaojin3616
yaojin3616 deleted the codex/generation-peer-policy branch September 11, 2026 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant