IMPR: test PRs via github actions #1272

Activity

1. d-v-b

   added

   enhancementIndicates new improvementsIndicates new improvements

   triageIndicates issues, pull requests, or discussions need to be reviewed for the first timeIndicates issues, pull requests, or discussions need to be reviewed for the first time

   on Sep 16, 2025
2. github-actions commented on Nov 1, 2025

   

   github-actionsbot

   on Nov 1, 2025 – with GitHub Actions

   More actions

   This issue is stale because it has been open for 45 days with no activity.
3. github-actions

   added

   staleIndicates issues, pull requests, or discussions are inactiveIndicates issues, pull requests, or discussions are inactive

   on Nov 1, 2025
4. dimitri-yatsenko

   added this to the DataJoint 2.0 milestone on Dec 20, 2025
5. dimitri-yatsenko

   removed

   triageIndicates issues, pull requests, or discussions need to be reviewed for the first timeIndicates issues, pull requests, or discussions need to be reviewed for the first time

   staleIndicates issues, pull requests, or discussions are inactiveIndicates issues, pull requests, or discussions are inactive

   on Dec 20, 2025
6. dimitri-yatsenko

   self-assigned this

   on Dec 22, 2025
7. dimitri-yatsenko commented on Jan 8, 2026

   

   dimitri-yatsenko

   on Jan 8, 2026

   Member

   More actions

   Updated the GitHub Actions workflow in commit dacf4ac on the docs-2.0-migration branch to properly run tests in CI:

   Changes

   1. MySQL service container: Uses GitHub Actions services with health checks
   2. MinIO container: Started manually via docker run (services don't support command)
   3. Environment variables: Set DJ_USE_EXTERNAL_CONTAINERS=1 plus all connection params
   4. Python matrix: Tests against 3.10, 3.11, 3.12, 3.13
   5. Separate unit-tests job: Runs without containers for faster feedback

   Workflow Structure

   jobs:
     test:           # Full integration tests with MySQL + MinIO
     unit-tests:     # Fast unit tests, no containers needed

   Remaining: Approval for Fork PRs

   GitHub requires approval for workflows from first-time contributors by default. Options:

   1. Repository Settings → Actions → "Fork pull request workflows" → adjust policy
   2. Or accept that maintainers need to approve first-time contributor PRs (security tradeoff)

   The updated workflow should run automatically for PRs from repo collaborators and approved contributors.
8. dimitri-yatsenko commented on Jan 8, 2026

   

   dimitri-yatsenko

   on Jan 8, 2026

   Member

   More actions

   Repository settings updated - fork PRs should now run tests automatically without requiring approval. This issue is addressed by the workflow changes in PR #1312.

   👍React with 👍1Reacted by Davis Bennett
9. dimitri-yatsenko

   added a commit that references this issue on Jan 8, 2026

   ci: add MySQL/MinIO services to GitHub Actions workflow

   ...

   dacf4ac
10. dimitri-yatsenko commented on Jan 9, 2026

    

    dimitri-yatsenko

    on Jan 9, 2026

    Member

    More actions

    Implemented in DataJoint 2.0

    PR testing via GitHub Actions is fully implemented:

    Features:

    • Automatic testing: All PRs trigger tests automatically (no approval required)
    • Unit tests: Fast tests without database (tests/unit/)
    • Integration tests: Full tests with testcontainers (tests/integration/)
    • Lint checks: ruff formatting and linting
    • Pre-commit hooks: mypy type checking, unit tests

    Workflow triggers:

    • Push to any branch
    • Pull requests to any branch
    • Path filters for relevant changes only

    See .github/workflows/test.yaml for implementation.
11. dimitri-yatsenko

    closed this as completedon Jan 9, 2026