Can't pass super.delete kwargs to Part.delete #1276

Activity

1. github-actions

   added

   triageIndicates issues, pull requests, or discussions need to be reviewed for the first timeIndicates issues, pull requests, or discussions need to be reviewed for the first time

   on Sep 24, 2025
2. dimitri-yatsenko

   self-assigned this

   on Sep 24, 2025
3. dimitri-yatsenko

   added

   enhancementIndicates new improvementsIndicates new improvements

   and removed

   triageIndicates issues, pull requests, or discussions need to be reviewed for the first timeIndicates issues, pull requests, or discussions need to be reviewed for the first time

   on Oct 16, 2025
4. github-actions commented on Dec 1, 2025

   

   github-actionsbot

   on Dec 1, 2025 – with GitHub Actions

   More actions

   This issue is stale because it has been open for 45 days with no activity.
5. github-actions

   added

   staleIndicates issues, pull requests, or discussions are inactiveIndicates issues, pull requests, or discussions are inactive

   on Dec 1, 2025
6. dimitri-yatsenko

   added this to the DataJoint 2.0 milestone on Dec 20, 2025
7. dimitri-yatsenko

   removed

   staleIndicates issues, pull requests, or discussions are inactiveIndicates issues, pull requests, or discussions are inactive

   on Dec 20, 2025
8. dimitri-yatsenko

   added 2 commits that reference this issue on Dec 25, 2025

   Allow Part.delete to pass kwargs through to Table.delete

   ...

   This issue will close once commit 9052492 is merged into the 'master' branch.

   9052492

   Add test for Part.delete kwargs pass-through

   ...

   This issue will close once commit 5e40c87 is merged into the 'master' branch.

   5e40c87
9. dimitri-yatsenko

   added a commit that references this issue on Jan 4, 2026

   Fix Part.delete to pass through kwargs to Table.delete

   ...

   This issue will close once commit 1e5afa5 is merged into the 'master' branch.

   1e5afa5
10. dimitri-yatsenko commented on Jan 9, 2026

    

    dimitri-yatsenko

    on Jan 9, 2026

    Member

    More actions

    Fixed in PR #1313

    The Part.delete() method now accepts and passes through **kwargs to super().delete().

    Implementation

    def delete(self, part_integrity: str = "enforce", **kwargs):
        """
        Delete from a Part table.
    
        Args:
            part_integrity: Policy for master-part integrity. One of:
                - "enforce" (default): Error - delete from master instead.
                - "ignore": Allow direct deletion (breaks master-part integrity).
                - "cascade": Delete parts AND cascade up to delete master.
            **kwargs: Additional arguments passed to Table.delete()
                      (transaction, prompt)
        """
        if part_integrity == "enforce":
            raise DataJointError(...)
        super().delete(part_integrity=part_integrity, **kwargs)

    Usage

    You can now pass transaction=False to wrap Part deletes in your own transaction:

    with dj.conn().transaction:
        # Multiple operations in single transaction
        MasterTable.Part().delete(part_integrity="ignore", transaction=False)
        other_operations()

    This will be available once #1313 is merged.

    👍React with 👍1Reacted by Samuel Bray
11. dimitri-yatsenko commented on Jan 9, 2026

    

    dimitri-yatsenko

    on Jan 9, 2026

    Member

    More actions

    Fixed in PR #1313 (merged). Part.delete() now passes **kwargs to super().delete().
12. dimitri-yatsenko

    closed this as completedon Jan 9, 2026