Skip to content

tests should not run on every commit #1356

Closed
#1363
Closed
tests should not run on every commit#1356
#1363
Labels
enhancementIndicates new improvements

Description

@d-v-b
d-v-b
opened on Jan 30, 2026

f195110 added a test workflow to pre-commit. I don't think this is a good idea.

  • pre-commit checks should be fast, and tests are not.
  • Tests are expected to fail on commits where you create a reproducer prior to committing the fix.

github workflows are a much better place for automated tests. I recommend removing tests from pre-commit checks.

Activity

  1. github-actions
    added
    triageIndicates issues, pull requests, or discussions need to be reviewed for the first time
    on Jan 30, 2026
  2. dimitri-yatsenko
    added
    enhancementIndicates new improvements
    and removed
    triageIndicates issues, pull requests, or discussions need to be reviewed for the first time
    on Jan 30, 2026
  3. dimitri-yatsenko
    added a commit that references this issue on Jan 30, 2026

    fix: Remove unit tests from pre-commit hooks

    ab596f0
  4. dimitri-yatsenko
    closed this as completedin #1363on Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementIndicates new improvements

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions