Repository navigation
Remove setuptools upper pin and otumat for maint/0.14 - #1571
Merged
dimitri-yatsenko merged 1 commit intoOct 5, 2026
Merged
dimitri-yatsenko merged 1 commit into
dimitri-yatsenko merged 1 commit into
Conversation
pkg_resources was removed in setuptools 82, and otumat (archived) imports distutils, which Python 3.12+ only provides through setuptools. Use importlib.metadata for plugin discovery and inline otumat's hash_pkg and verify, so datajoint no longer depends on setuptools or otumat. The plugin system and its signature check are unchanged. Assisted-by: ClaudeCode:claude-opus-5-5
dimitri-yatsenko
approved these changes
Oct 5, 2026
dimitri-yatsenko
left a comment
dimitri-yatsenko
left a comment
Member
There was a problem hiding this comment.
Thanks @tabedzki, this is a clean fix. I checked the copied hash_pkg/verify against otumat 0.3.1: hashes are identical across several real packages and an edge-case folder on Python 3.9–3.13, and the plugin tests pass without setuptools or otumat installed. We'll merge and cut 0.14.10 from maint/0.14.
dimitri-yatsenko
added
the
bug
Member
|
@tabedzki, merged, thanks. It will be published to PyPI as 0.14.10. Please note that this is not an official release: DataJoint no longer supports versions before 2.0, so the full test suite was not run. We ran only the plugin tests ( |
Contributor
Author
|
Noted. Thank you Dimitri! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @dimitri-yatsenko,
This PR replaces the
setuptools<82pin from datajoint/datajoint-python#1396 with theimportlib.metadatafix as suggested in datajoint/datajoint-python#1394. It also inlinesotumat's two functions, sootumatandsetuptoolsare no longer runtime dependencies, while keeping the plugin behavior unchanged.The main motivation stems from a shared database with DataJoint-MATLAB, which can't read 2.x schemas, so we're staying on 0.14.x.
Please let me know if there are any other changes you'd like to see in the PR and I'd be happy to address them.
The full test suite passes on Python 3.9–3.13, apart from 7 failures that also happen on unmodified
maint/0.14;PyMySQL1.2's new TLS default causes them.