Get-DbaExternalProcess, Stop-DbaExternalProcess - Restart only the Restart instance in the tests - #10730
Open
andreasjordan wants to merge 1 commit into
Open
Get-DbaExternalProcess, Stop-DbaExternalProcess - Restart only the Restart instance in the tests#10730andreasjordan wants to merge 1 commit into
andreasjordan wants to merge 1 commit into
Conversation
…start instance in the tests (do *DbaExternalProcess) Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
andreasjordan
marked this pull request as ready for review
September 20, 2026 19:48
potatoqualitee
approved these changes
Sep 21, 2026
potatoqualitee
left a comment
Member
There was a problem hiding this comment.
Reviewed the complete patch at this exact head, including service-resolution behavior, cleanup scope, both affected test files, discussions, and the applicable passing Azure restart lane. No material defects found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
AfterAllofGet-DbaExternalProcess.Tests.ps1andStop-DbaExternalProcess.Tests.ps1restarts the engine to release the temporary sql file, with-ComputerNamewith aDbaInstanceParameteruses only the computer part, so every engine on that host restarts, not only the Restart instance. On the lab, where the instances of a test set share one host, this restarted the Single instance twice during the parallel full runs of 2026-09-19/20 (SQL05 at 16:46 and SQL03 at 20:33) in the middle of other test files. On CI all instances of a lane live on the runner as well, so the same happens there.Both files now pass
-SqlInstance $TestConfig.InstanceRestartinstead, whichGet-DbaServiceresolves to that one instance.Test plan
sqlserver_start_timeof the three SQL03 instances before and after each run; only the Restart instance restarted.With the old line, the 2026-09-19/20 runs show all three instances of the host restarting at the moment these files ran.
created by Claude and reviewed by Andreas Jordan
🤖 Generated with Claude Code