Allow benchmarking larger-than-memory datasets - #721
Open
ashkrisk wants to merge 1 commit into
Open
Conversation
Contributor
|
Before you submit for review:
If you did not complete any of these, then please explain below. |
ashkrisk
force-pushed
the
ltm-ds/ltm-ds
branch
3 times, most recently
from
August 30, 2026 12:40
47442fb to
f11246a
Compare
Build on patches introduced earlier in the series to allow BenchYAML to process that don't fit in physical memory, by memory-mapping the index vectors instead of fully loading them upfront. This behaviour is opt-in and requires you to set `-Djvector.bench.dataset.mmap.enable=true` to enable. Additionally, fixes a concurrency issue with RAVV handling in Grid, and makes the output directories configurable Summary of changes: - Add a `RavvDataSet` wherein the index vectors are backed by a RAVV. - Add a function to `DataSetInfo` to return a `DataSet` backed by memory-mapped files, using `RavvDataSet`. - Consume the new `DataSet` from `BenchYAML` - Fix a concurrency issue in Grid where `RAVV#getVector` was being called from multiple threads at once - Make Grid's work directory and index cache directory configurable via environment variables. (Useful if you have an SSD on a separate mount)
ashkrisk
force-pushed
the
ltm-ds/ltm-ds
branch
from
August 31, 2026 04:54
f11246a to
da703e8
Compare
ashkrisk
marked this pull request as ready for review
August 31, 2026 06:17
ashkrisk
requested review from
MarkWolters,
jshook and
tlwillke
as code owners
August 31, 2026 06:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build on patches introduced earlier in the series to allow BenchYAML to process that don't fit in physical memory, by memory-mapping the index vectors instead of fully loading them upfront.
This behaviour is opt-in and requires you to set
-Djvector.bench.dataset.mmap.enable=trueto enable.Additionally, fixes a concurrency issue with RAVV handling in Grid, and makes the output directories configurable
Summary of changes:
RavvDataSetwherein the index vectors are backed by a RAVV.DataSetInfoto return aDataSetbacked by memory-mapped files, usingRavvDataSet.DataSetfromBenchYAMLRAVV#getVectorwas being called from multiple threads at once