fix: correct node-selector label domain to galactic.datumapis.com#225
Merged
Conversation
The galactic.datum.net/node label used to opt nodes into the route-reflector and edge roles pointed at the wrong domain; rename it to galactic.datumapis.com/node across config/, the containerlab lab manifests, and docs. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
scotwells
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
galactic.datum.net/nodelabel used to opt nodes into the route-reflector (control) and per-node (edge) roles used the wrong domaingalactic.datumapis.com/nodeacrossconfig/, all containerlab lab manifests (node configs, fabric/control daemonset patches), and docs (README.md,AGENTS.md/CLAUDE.md,docs/agents/ARCHITECTURE.md,deploy/containerlab/AGENTS.md)allocated-subnet,srv6-sid,netns,config-hash) were intentionally left unchanged — out of scope for this label fixTest plan
kubectl kustomize config/builds cleanly (verified locally)galactic.datumapis.com/nodebefore next lab bring-up