Skip to content

Use American spelling for initialize and initialization - #336

Open
tameware wants to merge 1 commit into
dds-bridge:developfrom
tameware:us-spelling-of-initialize
Open

Use American spelling for initialize and initialization#336
tameware wants to merge 1 commit into
dds-bridge:developfrom
tameware:us-spelling-of-initialize

Conversation

@tameware

Copy link
Copy Markdown
Collaborator

Summary

  • Standardize on American initialize / initialization spelling in comments, specs, and the Python API.
  • Rename the Python export initialise_static_memory to initialize_static_memory so it matches C++ InitializeStaticMemory. set_max_threads remains a deprecated alias and now points at the new name.

Test plan

  • bazelisk test //python:python_interface_smoke_test
  • bazelisk test //library/tests/system:max_threads_equivalence_test

Made with Cursor

Align the Python export initialize_static_memory with the C++ InitializeStaticMemory name.

Co-authored-by: Cursor <cursoragent@cursor.com>
@tameware
tameware requested a lite review from Copilot August 17, 2026 17:05
@tameware tameware self-assigned this Aug 17, 2026
@tameware
tameware requested a review from tzimnoch August 17, 2026 17:06

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR standardizes American spelling (“initialize” / “initialization”) across specs and API documentation, and updates the Python binding surface to expose initialize_static_memory in line with the C++ InitializeStaticMemory.

Changes:

  • Rename the Python-exported binding from initialise_static_memory to initialize_static_memory, and update related documentation strings.
  • Update specs, Bazel comments, and test comments to use American spelling consistently.
  • Extend Python import smoke coverage to assert initialize_static_memory is present/callable.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
specs/python-binding.md Updates the documented Python surface to reference initialize_static_memory.
specs/move-generation.md Replaces “initialisation” with “initialization” in invariants text.
specs/lookup-tables.md Standardizes “initialization” wording in lookup table lifecycle/contract spec.
python/tests/test_import.py Adds import + callable assertion for initialize_static_memory.
python/src/bindings.cpp Renames the exposed symbol and updates docstrings/deprecation text.
python/dds3/init.py Re-exports initialize_static_memory via package imports and __all__.
library/tests/system/max_threads_equivalence_test.cpp Standardizes spelling in test header/comments.
library/tests/system/BUILD.bazel Standardizes spelling in target comment.
library/src/init.cpp Standardizes spelling in internal comments for initialization.
library/src/api/dll.h Standardizes spelling in public C API documentation comments.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread python/dds3/__init__.py
Comment thread python/src/bindings.cpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants