Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/node.js
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,12 @@ exports.inspectOpts = Object.keys(process.env).filter(key => {
return obj;
}, {});

// `DEBUG_HIDE_DATE` is commonly set as a flag without a value.
if (Object.prototype.hasOwnProperty.call(process.env, 'DEBUG_HIDE_DATE') &&
process.env.DEBUG_HIDE_DATE === '') {
exports.inspectOpts.hideDate = true;
}

/**
* Is stdout a TTY? Colored output is enabled when `true`.
*/
Expand Down
29 changes: 29 additions & 0 deletions test.node.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
/* eslint-env mocha */

const assert = require('assert');
const {spawnSync} = require('child_process');
const util = require('util');
const sinon = require('sinon');
const debug = require('./src/node');
Expand Down Expand Up @@ -36,5 +37,33 @@ describe('debug node', () => {
assert.deepStrictEqual(util.formatWithOptions.getCall(0).args[0], options);
stdErrWriteStub.restore();
});

it('honors DEBUG_HIDE_DATE when set as a flag', () => {
const script = `
const tty = require('tty');
tty.isatty = () => false;
const debug = require('./src/node');
debug.enable('test');
const log = debug('test');
const args = ['hello'];
debug.formatArgs.call(log, args);
process.stdout.write(args[0]);
`;

for (const hideDate of ['', '1', 'true']) {
const result = spawnSync(process.execPath, ['-e', script], {
cwd: __dirname,
env: {
...process.env,
DEBUG: 'test',
DEBUG_HIDE_DATE: hideDate
},
encoding: 'utf8'
});

assert.strictEqual(result.status, 0, result.stderr);
assert.strictEqual(result.stdout, 'test hello');
}
});
});
});