docs: fix hex example to match the Buffer it formats - #1054
Open
JiuYue0820 wants to merge 1 commit into
Open
JiuYue0820 wants to merge 1 commit into
JiuYue0820 wants to merge 1 commit into
Conversation
Co-authored-by: FirmamentalSpring <287222957+FirmaSpring@users.noreply.github.com>
lbesecker195
approved these changes
Sep 13, 2026
lbesecker195
left a comment
There was a problem hiding this comment.
Checked: Buffer.from('hello world').toString('hex') gives 68656c6c6f20776f726c64, so the old comment had a stray 21 (!) that isn't in the input. The README on master (line 210) still uses the deprecated new Buffer(...), and Buffer.from is the drop-in replacement. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The custom formatters example reads:
Two things are wrong:
new Buffer(...)is deprecated since Node.js 6; the modern equivalent isBuffer.from(...).21(the hex of!), which is not part of the input string'hello world'.Buffer.from('hello world').toString('hex')is68656c6c6f20776f726c64.Solution
Use
Buffer.fromand drop the stray21so the comment matches the actual formatter output.Verification
Documentation-only change.