CMake: Fix RapidJSON target for non-MPI builds - #7795
Open
Growl1234 wants to merge 1 commit into
Open
Conversation
mohanchen
added
the
Compile & CICD & Docs & Dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The target
json_outputwas created only when both RapidJSON and MPI were enabled, while the executable links againstjson_outputwheneverENABLE_RAPIDJSON=ON. As a result, non-MPI builds could treatjson_outputas a plain library name and fail at link time with:However, the MPI requirement is only relevant to the tests under
module_json; thejson_outputtarget itself already handles non-MPI builds correctly.Therefore, this PR removes the redundant MPI guard from the parent CMake logic.