Skip to content

Raise error when from_deepmd_npy_mixed with not-a-directory para. #432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iProzd wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Raise error when from_deepmd_npy_mixed with not-a-directory para. #432

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1cf263a
Raise error when dpdata.MultiSystem calls from_deepmd_npy_mixed with …
iProzd Mar 12, 2023
91deabf
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Mar 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions dpdata/plugins/deepmd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,7 @@ def mix_system(self, *system, type_map, **kwargs):

def from_multi_systems(self, directory, **kwargs):
sys_dir = []
assert os.path.isdir(directory), f"{directory} is not a directory!"

@wanghan-iapcm wanghan-iapcm Mar 13, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please raise FileNotFoundError. One has not chance of catching the error with assertion!
Plz also add a UT for it.

@njzjz-bot njzjz-bot Aug 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P2] Do not use assert for user-supplied path validation

python -O removes this check entirely; on this head a regular file then walks as no directories and returns an empty result. Raise an explicit exception so callers receive the same behavior in optimized and normal runs.

Suggested change
assert os.path.isdir(directory), f"{directory} is not a directory!"
if not os.path.isdir(directory):
raise FileNotFoundError(f"{directory} is not a directory!")

for root, dirs, files in os.walk(directory):
if (
"type_map.raw" in files
Expand Down