Add post_func_skip_list to control execution of post functions - #644
Add post_func_skip_list to control execution of post functions#644ZLI-afk wants to merge 3 commits into
post_func_skip_list to control execution of post functions#644Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devel #644 +/- ##
==========================================
- Coverage 83.67% 83.65% -0.02%
==========================================
Files 80 80
Lines 7006 7011 +5
==========================================
+ Hits 5862 5865 +3
- Misses 1144 1146 +2 ☔ View full report in Codecov by Sentry. |
njzjz-bot
left a comment
There was a problem hiding this comment.
Requesting changes because constructing an empty System and loading it later raises AttributeError before any post function can run. The branch must initialize this state before both constructor early returns, then be rebased and covered by chained-loading tests.
Process note: the Codex usage allowance is about to reset, so I am spending the remaining token budget now on this review.
Coding agent: Codex
Codex version: codex-cli 0.144.6
Model: gpt-5.6-sol
Reasoning effort: xhigh
| return | ||
| if file_name is None: | ||
| return | ||
| self.post_func_skip_list = ( |
There was a problem hiding this comment.
[P1] Initialize the skip list before either early return
System() returns at file_name is None without defining post_func_skip_list. A later System().from_fmt(...) reaches the post-function branch and raises AttributeError, which I reproduced on this head. Move this initialization above both the data and file_name early-return blocks, and add a chained empty-constructor loading regression test. A complete GitHub suggestion cannot be attached to only these added lines because the fix must move them above unchanged context.
In respond to required function associated with recent discussion topic #641 and #642