test: cover empty tool results - #12460
Conversation
|
Someone is attempting to deploy a commit to the deepset Team on Vercel. A member of the Team first needs to authorize it. |
|
nightcityblade seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
Hi @nightcityblade, thanks a lot for your contribution! 🙏 We noticed that the Contributor License Agreement (CLA) check ( To get your PR reviewed, please sign the CLA via the link in the |
|
Hi @nightcityblade, just a friendly reminder: this PR is still in draft because the Contributor License Agreement (CLA) hasn't been signed yet. We'd love to review your contribution! Please sign the CLA via the link in the |
Related Issues
Proposed Changes:
Add parameterized regression coverage for tools that successfully return an empty string, list, or dictionary. The tests exercise both synchronous and asynchronous invocation and verify serialization, success status, and tool-call correlation.
How did you test it?
hatch run test:unit test/components/agents/test_tool_calling.py -q— 71 passedhatch run pre-commit run --files test/components/agents/test_tool_calling.py— all hooks passedhatch run fmt test/components/agents/test_tool_calling.py— passed, unchangedNotes for the reviewer
This is test-only regression coverage; runtime behavior is unchanged.
Checklist
test:conventional commit type for my PR title.