test: enable mypy typing checks for test/components/extractors - #12483
Merged
davidsbatista merged 2 commits intoAug 27, 2026
Merged
Conversation
The directory already type-checks cleanly, but was never added to the `types` target, so CI was not running mypy over it and a regression introduced there would have gone unnoticed. Adding the path closes that gap; no source changes were needed.
ShousenZHANG
requested review from
a team and
bogdankostic
and
a lite review from Copilot
and removed request for
a team
August 27, 2026 04:23
|
@ShousenZHANG is attempting to deploy a commit to the deepset Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
There was a problem hiding this comment.
Pull request overview
- Ensure
hatch run test:types(mypy) includestest/components/extractors/so those extractor tests are covered by CI type-checking, as part of the incremental rollout tracked in #10396.
Changes:
- Add
test/components/extractors/to the mypy target list in the Hatchtestenvironmenttypesscript (kept in alphabetical order aroundevaluators/andgenerators/).
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Coverage report
This PR does not seem to contain any modification to coverable code. |
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
davidsbatista
requested review from
davidsbatista
and removed request for
bogdankostic
August 27, 2026 13:38
davidsbatista
approved these changes
Aug 27, 2026
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
test/components/extractors/was not in the repository mypy target, so its five modules were not being checked byhatch run test:types. Claimed in this comment; it does not overlapfetchers/(#12435), the only other increment in flight.Unlike the previous increments, this one needs no source changes. The directory already type-checks cleanly against
main— the path was simply never added to the target, so CI has not been running mypy over it. Any typing regression introduced in those tests today would go unnoticed. This adds the path and closes that gap.The single line changed keeps the target list in alphabetical order (
evaluators/->extractors/->generators/).How did you test it?
mypy test/components/extractors/againstmain, before the change:Success: no issues found in 5 source files— confirming the directory is already clean and the gap is purely in coverage.hatch run test:types->Success: no issues found in 468 source files(461 before).hatch run test:unit test/components/extractors/-> 86 passed, 5 deselected.hatch run fmt-check-> clean across the repo (6785 files).Notes for the reviewer
Happy to fold this into another PR if a one-line change on its own is noisier than it is worth — it seemed better to surface the coverage gap than to leave it.
No release note: this is test/CI configuration only, which AGENTS.md excludes from the release-note requirement.
This PR was fully generated with an AI assistant. I have reviewed the changes and run the relevant tests.
Checklist